Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce API for changing the status bar colour #7556

Merged
merged 5 commits into from
Apr 18, 2023
Merged

feat: Introduce API for changing the status bar colour #7556

merged 5 commits into from
Apr 18, 2023

Conversation

Nokel81
Copy link
Collaborator

@Nokel81 Nokel81 commented Apr 14, 2023

resolves #7546

Screen Shot 2023-04-14 at 3 44 52 PM
Screen Shot 2023-04-14 at 3 45 17 PM
Screen Shot 2023-04-14 at 3 45 24 PM

@Nokel81 Nokel81 added enhancement New feature or request area/extension Something to related to the extension api labels Apr 14, 2023
@Nokel81 Nokel81 added this to the 6.5.0 milestone Apr 14, 2023
@Nokel81 Nokel81 requested a review from a team as a code owner April 14, 2023 19:49
@Nokel81 Nokel81 requested review from Iku-turso and jim-docker and removed request for a team April 14, 2023 19:49
Nokel81 added 5 commits April 17, 2023 12:38
@Nokel81
feat: Introduce API for changing the status bar colour
e883b28 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
chore: Revert exposing api to legacy extension API
b02b45f 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
chore: Expose api to only bundled extensions
54dc0de 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
fix: change class name behaviour to limit snapshot diffs
425af8c 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
chore: Fix spelling of helper function
806de79 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 force-pushed the bottom-bar-colours branch from a66a0f1 to 806de79 Compare April 17, 2023 16:38
aleksfront
aleksfront approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@aleksfront aleksfront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nokel81 Nokel81 merged commit 4fb21af into master Apr 18, 2023
@Nokel81 Nokel81 deleted the bottom-bar-colours branch April 18, 2023 12:16
@Nokel81 Nokel81 mentioned this pull request Apr 18, 2023
Merged
chenhunghan
chenhunghan reviewed Apr 25, 2023
View reviewed changes
packages/open-lens/integration/__tests__/cluster-pages.tests.ts
@@ -86,7 +86,7 @@ describeIf(minikubeReady(TEST_NAMESPACE))("Minikube based tests", () => {
10 * 60 * 1000,
);

it(
it.only(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably not intended.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already reverted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenhunghan chenhunghan chenhunghan left review comments

@aleksfront aleksfront aleksfront approved these changes

@gabriel-mirantis gabriel-mirantis gabriel-mirantis approved these changes

@Iku-turso Iku-turso Awaiting requested review from Iku-turso Iku-turso is a code owner automatically assigned from lensapp/lens-ide

@jim-docker jim-docker Awaiting requested review from jim-docker jim-docker is a code owner automatically assigned from lensapp/lens-ide

Assignees
No one assigned
Labels
area/extension Something to related to the extension api enhancement New feature or request
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.

Add ability to set colour of bottom bar
4 participants
@Nokel81 @chenhunghan @aleksfront @gabriel-mirantis